Loopback tests for URLSession #613
Conversation
| ] + glob.glob('./TestFoundation/Test*.swift')) # all TestSomething.swift are considered sources to the test project in the TestFoundation directory | ||
|
|
||
| Configuration.current.extra_ld_flags = '-L'+Configuration.current.variables["LIBDISPATCH_BUILD_DIR"]+'/src/.libs' |
There was a problem hiding this comment.
@seabaylea : In build.py, TestFoundation is built as a SwiftExecutable without the linker options, this results in /usr/bin/ld.gold failing to locate libdispatch. I can see that a the rule for SwiftExecutable uses EXTRA_LD_FLAGS. Hence added this line. Can you please comment on this?
There was a problem hiding this comment.
That makes sense - its what we have to do when building Foundation as Dispatch isn't yet in the right place (as we're still building the toolchain)
pushkarnk
force-pushed
the
loopback
branch
2 times, most recently
from
51a79b4 to
3bd7f80
Compare
|
Added support to test download tasks. I need to work on making this build and run on Darwin next. |
|
How's this going? |
|
I need to make this build and run on Darwin. |
pushkarnk
force-pushed
the
loopback
branch
3 times, most recently
from
5df83f7 to
410bfbe
Compare
|
@parkera : I've updated the Xcode project. Can you please run a test? |
| typealias FoundationObject = NSObject | ||
| #else | ||
| typealias FoundationObject = SwiftFoundation.NSObject | ||
| #endif |
There was a problem hiding this comment.
This looks awkward. But I found the use of NSObject causing a "NSObject ambiguous for type lookup in this context" compiler error with Xcode.
There was a problem hiding this comment.
I'd like to understand more about the root cause of this error. Clients of Foundation should absolutely be able to subclass NSObject without this kind of hackery.
|
The ambiguity error comes from the |
| @@ -467,8 +467,11 @@ | |||
| # TODO: Probably this should be another 'product', but for now it's simply a phase | |||
| foundation_tests = SwiftExecutable('TestFoundation', [ | |||
| 'TestFoundation/main.swift', | |||
| 'TestFoundation/HTTPServer.swift', | |||
There was a problem hiding this comment.
Should this file go in the swift_sources list?
There was a problem hiding this comment.
I am not sure. But swift_sources seems to be holding all the swift source files that are compiled into Foundation. HTTPServer.swift needs to be compiled into TestFoundation.
There was a problem hiding this comment.
You're right, the other test files are found via the glob. I guess this is ok. I'm going to kick off a test.
|
@swift-ci please test |
This is a very basic HTTP server for loopback tests for URLSession. I have borrowed some implementation aspects from the HTTPServer.swift in PR 299. The server currently, listens, reads and writes only once. It is possible to test data tasks and download tasks. Opening this PR for review and comments.
I also had to make a small change to build.py to get TestFoundation built with Dispatch.